[
https://issues.apache.org/jira/browse/YUNIKORN-2794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Condit resolved YUNIKORN-2794.
------------------------------------
Fix Version/s: 1.6.0
Target Version: 1.6.0
Resolution: Fixed
Merged to master.
> Resource: Change SubOnlyExisting() to same signature as AddOnlyExisting()
> -------------------------------------------------------------------------
>
> Key: YUNIKORN-2794
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2794
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Tzu-Hua Lan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The AddOnlyExisting function takes two resource objects and returns a new
> object. The SubOnlyExisting method is called on a resource receiver modifying
> the receiver object.
> These two should use the same kind of signature taking two resource objects
> and returning a new object. In most use cases for SubOnlyExisting we do a
> clone before we call within a locked method on an object that contains the
> resource.
> This clone becomes obsolete when we make the change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
