Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/921
@cloverhearts Thanks for the contribution!
What could be the reason for creating `JobManagerServer` instead of using
existing `NotebookServer`?
Creating `JobManagerServer` seems results produce many duplicated codes.
Many methods in `JobManagerServer` have duplicated code from
`NotebookServer`,
`JobManagerSocket` is identical to `NotebookSocket`,
`JobManagerSocketListener` is identical to `NotebookSocketListener`
`JobManagerWebSocketCreator` is identical to `NotebookWebSocketCreator`
`websocketCalls.jobManagerServer` has many duplicated code to
`websocketCalls.notebookServer` in `websocketEvents.factory.js`
Can we just use NotebookServer or find a better way to minimize code
duplication?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
