Hi Onkar,

glad to see that your exams are over and you are focusing on the GSoC
project!

Your plan sounds good as short-term solution.
Do you know IFPS have any plans to publish it? It might be worth asking for
it [1] and expressing the interest.

Implementation-wise - it might be better to use ipfs jar, manually
installed in your existing local maven repository (~/.m2). It will
just require users to install it first, and then project can be built as
usually.

Do not forget to document this at least in some README file that will be
part of your PR,  as well as precise instructions (mvn install:install-file
...) for users on how to install this third-party library to their locally
repository. Here is a good starting point on learning how to do that [2].

On the side-note - I think now may be a good time to start a long living
branch with your work and submit a PR to Zeppelin with "[WIP] ...." in
title, so your work would become more visible.


1. https://github.com/ipfs/java-ipfs-api/issues/1
2. https://maven.apache.org/guides/mini/guide-3rd-party-jars-local.html

On Tue, Jun 7, 2016 at 9:14 AM, onkar shedge <[email protected]>
wrote:

> This worked for me, don't know if it is a good practice. I created a
> directory 'local-repo' in base project and this in zeppelin-zengine pom.xml
>
> <repositories>
>     <repository>
>       <id>local-repo</id>
>       <url>file://${project.parent.basedir}/local-repo</url>
>     </repository>
> </repositories>
>
> and also the dependency part
> <dependency>
>       <groupId>org.ipfs</groupId>
>       <artifactId>api</artifactId>
>       <version>0.0.1-SNAPSHOT</version>
>  </dependency>
>
>
> On Tue, Jun 7, 2016 at 10:43 AM, onkar shedge <[email protected]>
> wrote:
>
> > The java-ipfs-api is not present in the central maven repository. And I
> > want to add it as a dependency in zeppelin-zengine. So how should i add
> it ?
> >
> > 1] https://github.com/ipfs/java-ipfs-api
> >
> > Regards,
> > Onkar Shedge.
> >
>

Reply via email to