Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/965
Thanks @astroshim for the improvement. I've tested and although it's
working well, i think there're little more things we can think
1. Normalization is not applied when change note name.
2. Normalization routine need to be placed in zeppelin-zengine, rather than
zeppelin-server
zeppelin-server is place for the code that enables front-end / back-end
communication.
business logic handles notebook should be in zeppelin-zengine module.
3. It would be great to have a unittest for normalize note name
4. Note name display is bit inconsistent.
with this branch
| Given name when create note | note name displayed on screen |
| ------------- | ------------- |
| MyNote | MyNote |
| /MyNote | /MyNote |
| MyNote/sub | **/MyNote/sub** |
| /MyNote/sub | /MyNote/sub |
but it should be like
| Given name when create note | note name displayed on screen |
| ------------- | ------------- |
| MyNote | MyNote |
| /MyNote | /MyNote |
| MyNote/sub | **MyNote/sub** |
| /MyNote/sub | /MyNote/sub |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
