Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1007
Thank you for addressing feedback promptly.
Well, in my oppinion, if by "encourage more versioned implementation" you
mean having this code duplicated 5 times around the code base
```java
@Override
public Note get(String noteId, Revision rev) throws IOException {
// Auto-generated method stub
return null;
}
```
it looks like not very elegant solution.
It looks more meaningful and elegant to having 2 separate interfaces
(types) documented, 1 for non-versioned backends and 1 for versioned ones to
allow authors to choose from.
Otherwise, if we extend the suggested logic - why do not just to type
everything as `Object` and keep only 1 interface for everything? It kind of
defeats the benefits of having a type system.
It's not a strong opinion though, and if after this arguments, you still
feel that having single one is better - please let me know.
Other that this issues - it looks great to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
