GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1081
[ZEPPELIN-846] Fix Long Notebook Dropdown
### What is this PR for?
This PR is fixing the bug by implementing a new layout for the Notebook
Dropdown menu.
Reason being that setting a maximum height and having a scrollbar doesn't
mix with having bootstrap submenus.
In term of dropdown layout, I think we have 2 options:
* The one I implemented, a tree view similar to the one in the home page, I
can probably uniform both of them later. One possible problem is the dropdown
width getting bigger and bigger as we indent at each submenu.
* The second one would not have any indent, but use a background color to
show elements in the same folder (A grey that goes clearer as we go in the
submenus)
<img width="691" alt="screen shot 2016-06-25 at 1 42 41 am"
src="https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png";>
Reworking the whole notebook list and dropdown will probably need a lot
more work later (especially in term of refactoring and code cleaning), so I'm
not sure where the scope of this PR should stop, especially with the release
coming. I think the layout I implemented is fine to solve the immediate
problem, and it is always possible to switch to the layout of option 2 later if
we think it is best.
### What type of PR is it?
Hot Fix
### Todos
* [ ] - Fix Notebook order in the Dropdown
* [ ] - Open the folders to show the current note?
* [ ] - Rebase & Double Check the filtering after #1066
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-846
### How should this be tested?
Just play with the folder structure and check the notebook dropdown
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin
fix/longNavbarNotebookList
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1081
----
commit a5b2bb8afaa8e11714aa271f5aa28238d369fcd2
Author: Damien CORNEAU <[email protected]>
Date: 2016-06-24T16:19:41Z
Change Notebook dropdown style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
![https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png"](https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png"){kind=link}
