GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1088

    [ZEPPELIN-1062] Get original InterpreterSetting when there is no change

    ### What is this PR for?
    When we update interpreter property values, we edit some values and click 
"save" button. Then a bootstrap dialog is show up. In this step, if we click 
"cancel", the updated value is still existed in the table. This new value is 
not stored actually. After refresh, the original value will be shown. 
    
    I just get original InterpreterSetting(`getInterpreterSettings()`) when 
there is no change(`result`) for fixing this bug.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    
    ### What is the Jira issue?
    [ZEPPELIN-1062](https://issues.apache.org/jira/browse/ZEPPELIN-1062)
    
    ### How should this be tested?
    It's really simple. Just see the below attached screenshots. 
    
    ### Screenshots (if appropriate)
     - Before
    
![interpreter_setting](https://cloud.githubusercontent.com/assets/10060731/16358958/461a1d32-3ad8-11e6-849f-5010caed4e4d.gif)
    
    - After
    
![after](https://cloud.githubusercontent.com/assets/10060731/16358964/79af0ad6-3ad8-11e6-93aa-95897ece8b9a.gif)
    
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-1062

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1088
    
----
commit ee0d0d8061729f316e2b5873a81bd4b5bc55fbf5
Author: AhyoungRyu <[email protected]>
Date:   2016-06-25T20:23:58Z

    Get original InterpreterSetting when there is no change

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to