GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/1101

    [ZEPPELIN-1072] Saving Interpreter Setting dosen't notify when its finished

    ### What is this PR for?
    When user tries to save Interpreter Setting, it does not notify user when 
its done.
    In cases where saving setting includes adding dependencies, it can take 
longer than 10 seconds, depending on number of dependencies added.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    * [x] - add fa-spin with OK button
    
    ### What is the Jira issue?
    * [ZEPPELIN-1072](https://issues.apache.org/jira/browse/ZEPPELIN-1072)
    
    ### How should this be tested?
    Try loading a dependency in any of the interpreter, you will notice "OK" 
button is replaced by loading icon.
    
    ### Screenshots (if appropriate)
    
![zeppelin-1072](https://cloud.githubusercontent.com/assets/674497/16409449/3df5fb34-3d3b-11e6-8d3e-457022e7269e.gif)
    
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1072

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1101
    
----
commit 8d4387c026e402e83804faab5e4d569d33cddf8e
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2016-06-28T08:27:17Z

    add fa-spin with OK button

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to