GitHub user corneadoug opened a pull request:

    https://github.com/apache/zeppelin/pull/1204

    [Zeppelin-1089] Replace JsHint with Eslint

    ### What is this PR for?
    This PR replace JsHint with Eslint, the original configuration was ported 
from jsHint using [Polyjuice](https://www.npmjs.com/package/polyjuice), then 
setting were tuned better.
    For this PR, the goal is not to add new rules, but only to replace the 
system with the same rules.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Add dev licenses for grunt-eslint
    * [ ] - Remove license for jsHint
    * [ ] - Remove .jshintrc
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1089
    
    ### How should this be tested?
    You can simply build the code.
    You can try to add an unused variable in the js code to see an error.
    
    ### Questions:
    * Does the licenses files need update? Yes
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1089

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1204
    
----
commit 7b1da053cc8feb302ede04e95b6bdd10fc6933ea
Author: Damien CORNEAU <[email protected]>
Date:   2016-07-19T09:40:00Z

    Replace JsHint by Eslint

commit 0364ad48d03770603a2a952a1077e717cba107f7
Author: Damien CORNEAU <[email protected]>
Date:   2016-07-19T10:00:43Z

    Fix eslint for tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to