GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1258

    [ ZEPPELIN-1266 ] Code editor Optimization

    ### What is this PR for?
    If the result of many para- graph, the code editor is very slow.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    - [x] removed call to function in template.
    - [x] changed event (aceChange event to ace input event)  
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1266
    
    ### How should this be tested?
    1. going to r tutorial notebook.
    2. write to paragraph on anyway. (many many.. fast.. fast typing.)
    
    ### Screenshots (if appropriate)
    #### Before optimization.
    
![performance02](https://cloud.githubusercontent.com/assets/10525473/17323111/a1cd9b2e-58db-11e6-8d61-7ab98ea96b3a.gif)
    
    #### After optimization.
    
![performance01](https://cloud.githubusercontent.com/assets/10525473/17323107/a02b5338-58db-11e6-95c8-543aab7131dd.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin dev/aceeditorperformance

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1258
    
----
commit 86ba5c42a6eb9ea9ba22d90c11dbb823e5b81ce2
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-08-02T07:19:30Z

    ace editor performance up

commit 979e2f3a05bdeba14f297d0bcb4e85d1e593424a
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-08-02T08:20:28Z

    ace editor performance up - remove call to template function

commit af5e18f275ebe0850649e7956c1be3673214aaf0
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-08-02T08:38:09Z

    ace editor optimize - get isChange paragraph text value in template

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to