GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1277
[ZEPPELIN-1257] Decouple revision id handling
### What is this PR for?
This PR is to decouple Revision from RevisionId and let users to provide
their own RevisionId class as a generic input to the provided RevisionId class.
### What type of PR is it?
Improvement | Refactoring
### Todos
* [x] - Separate Revision class
* [x] - Decouple RevisionId class as generic
* [x] - Update api for getNoteRevision to accept RevisionId instead of
Revision
### What is the Jira issue?
[ZEPPELIN-1257](https://issues.apache.org/jira/browse/ZEPPELIN-1257)
### How should this be tested?
CI green
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
improve/revision-id-handling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1277
----
commit 75debf71c443b1f7a5b1f62b09ad65623fccdd98
Author: Khalid Huseynov <[email protected]>
Date: 2016-08-03T14:12:29Z
decouple revision and provide revision id as generic class
commit 9e739604feb7a6c5eeda9bd9f32fcd5ad7f6e3ee
Author: Khalid Huseynov <[email protected]>
Date: 2016-08-03T16:45:32Z
substitute api with RevisionId and propagate up
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
