GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1287
[Optimization] Code editor key binding event optimization.
### What is this PR for?
zeppelin custom key binding event optimization for Ace Code editor
### What type of PR is it?
Improvement
### Todos
- [x] optimization for key binding and check logic
### How should this be tested?
For many in the code editor and typing quickly.
The effect is greater when there are many Paragraph.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
dev/codeditorKeyBindOptimization
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1287
----
commit b37788d70d665db72514bf97689571f1a9fe4fe2
Author: CloverHearts <[email protected]>
Date: 2016-08-05T04:15:54Z
Code editor key binding event optimization.
commit 8cc63b7677f4db4a48fba9eb895bfc66cc3f5a77
Author: CloverHearts <[email protected]>
Date: 2016-08-05T04:28:58Z
fixed syntax error for editor key binding optimization.
commit 6a9edbe877fcc6fb5a59bac809c1b11b42cea96d
Author: CloverHearts <[email protected]>
Date: 2016-08-05T05:07:40Z
change access type $scope access member to local variable and add last row
check logic
commit e4c37b19d0da7025788dde9aef63d5a4d8b43544
Author: CloverHearts <[email protected]>
Date: 2016-08-05T05:32:07Z
move to original key bind function for codeeditor optimiza
commit 27f7146f790e35956a2e1dd3fa1f65bbadb3051e
Author: CloverHearts <[email protected]>
Date: 2016-08-05T05:37:06Z
Modify the style syntax for code editor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
