Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/989
@onkarshedge great progress, thank you for keeping us posted!
Before moving further, on top of great suggestions from @corneadoug, there
are few more things you also need to take care of:
- Please make sure that `zeppelin-distribution/src/bin_license/LICENSE`
includes all dependencies _AND all transitive dependencies_ that this changes
bring to the project. You can see them with `mvn dependency:tree`
- Please make sure that ALL your Java code follows the conventions from
[project style
guide](https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#code-convention)
- I noticed that CI is failing here. Could you, as an author of the PR,
look into that and post there the reason of the failures here please? This
would speed up the review and enable the reviewers to help you identify the
reason faster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
