Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@AhyoungRyu great initiative, but while making this changes, you have to
think also about CI use case of zeppelin build as well.
I.e so far `/.spark-dist/` is under cache on TravisCI which is S3 bucket
that gets synced automatically with the content of this folder while running a
build. It you un-tar the whole archive there - it will take forever to sync \w
S3 and will defeat the purpose of cache on CI side, making build times longer.
If you ask me - I would say that before doing such big changes as
refactoring of the build structure we all need very clear understanding and
explanation of `what is the benefit` and what problem does this change solves.
So far I have not understood the answer to the questions above from PR
description (may be my fault). But, in case of voting for such change, will
make me at least `-0` for if, if not `-1` due to potential bugs that such
changes will bring.
If that is reduction of convenience binary size - then we need to know how
much does the size changes with the proposed changes to understand if that is
worth. If that impacts CI build times - we also need to know how much.
Also regarding user experience - while running `zeppelin-demon.sh` user
does not usually expect it to be network-dependant and download 100Mb archives
- is there at least a user notification\progress indicator? Otherwise there
going to be bug reports like "Zeppelin is not starting" as soon as such change
is introduced.
And how about Windows users of Zeppelin? How about EMR\Dataproc\Juju\BigTop
users, will the proposed change affect them?
Please take it with the grain of salt, and of course I will be happy to
help addressing each item addressed one by one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
