GitHub user corneadoug opened a pull request:

    https://github.com/apache/zeppelin/pull/1355

    [ZEPPELIN-1359] Commit correctly ordered karma.conf file

    ### What is this PR for?
    In the karma-conf.js file, dependencies are usually alphabetically ordered.
    On a clean repo build, the file is changed to be alphabetically order those 
dependencies.
    SInce one of those is not in the right order, it creates a modified file in 
the repository after build.
    
    This PR is simply re-ordering the file so that there is no modifications on 
build.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1359
    
    ### How should this be tested?
    Build the source code from a clean repo, there shouldn't be any file 
changed if you type `git status`
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1359

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1355
    
----
commit 6d9a8da1e4575eef33f0d6ee6a2fe61ad3d67e33
Author: Damien CORNEAU <cornead...@gmail.com>
Date:   2016-08-23T07:27:58Z

    Add correct karma.conf.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to