Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1384
  
    The change of library looks great to me, 👍  for having a test case!
    
    Few things to take care of, before merging it:
     - for all the code, please make sure it follows project [styleguide\code 
conventions](https://github.com/apache/zeppelin/blob/master/CONTRIBUTING.md#code-convention)
     - as you add a new dependency - it will become a part of the next release 
convenience binary for Zeppelin and in order to be included, we need to verify 
it's licence compatibility. Can you please add it to 
`zeppelin-distribution/src/licence_bin/LICENSE`
     - also, applying some styles for such tables, as noted by @AhyoungRyu 
sounds like a good improvement as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to