GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1384
[ZEPPELIN-1387] Support table syntax in markdown interpreter ### What is this PR for? Support table markdown syntax issued by [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. ### Todos * [ ] - Check the license issue of the [pegdown](https://github.com/sirthias/pegdown) library introduced by this PR ### What is the Jira issue? [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### How should this be tested? Write markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR. ### Screenshots (if appropriate) <img width="708" alt="markdown" src="https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png"> ### Questions: * Does the licenses files need update? * Does coding style is appropriate? ### Additional Comments We might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark](https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef). But I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j. You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 ---- commit 029f550a04721c786b1d0021ac9551f2a6e62aed Author: 1ambda <1am...@gmail.com> Date: 2016-08-29T17:44:21Z [ZEPPELIN-1387] Support table in markdown interpreter commit fa14b3ed75c051ad6da0e3955ef8debf4d231b13 Author: 1ambda <1am...@gmail.com> Date: 2016-08-30T15:44:13Z style: Apply google java code style guide commit 7aecdcb536a7561fb67f2e1404d4bcb3921774da Author: 1ambda <1am...@gmail.com> Date: 2016-08-30T15:55:47Z chore: Add pegdown to the binary license list commit 603d3db4068f1eed5a8647489da80c945ac23cfb Author: 1ambda <1am...@gmail.com> Date: 2016-08-31T04:18:25Z fix: Add missing transitive deps for pegdown commit f7419492adde2ad0d71e8f189b3a4ace9a80a9a8 Author: 1ambda <1am...@gmail.com> Date: 2016-08-31T18:19:20Z fix: Add styles for markdown - Wrap parsed DOM with div which has `markdown` class attr - Style them with github flavored markdown style ([github-markdown-css](https://github.com/sindresorhus/github-markdown-css)) - add [github-markdown-css](https://github.com/sindresorhus/github-markdown-css) license to `zeppelin-distribution` commit 9cf31d0bbc9db4b8be2ab1e1ca62b72c7d596cca Author: 1ambda <1am...@gmail.com> Date: 2016-09-01T14:25:26Z fix: Use markdown-body class (default) commit c33c71590ae8dd5fbe09091d95d6f81614bf3e43 Author: 1ambda <1am...@gmail.com> Date: 2016-09-01T15:28:24Z fix: Remove the ANCHORLINKS option - added some markdown syntax tests commit 55a2f1025483b8be705bfd94734c968a6acfa9ce Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:24:35Z fix: Add MarkdownParser interface to support mulitple parsers commit bf9100de31fb630ea19c61eda0f9b89f8382dd20 Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:25:03Z chore: Restore markdown4j dependency commit d2d4455118191dfc89fc789dfefecfccc4c210cb Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:28:50Z style: Reformat using intellij-java-google-style commit 2b6516cad31b08d12d0f2e76d3bca3a1c8209eb7 Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T16:49:06Z feat: Support markdown.parser.type attr in md commit d228423d636c2d7d9ca4d8c7b7c211433c5c0706 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T04:33:49Z docs: Update markdown docs config, examples commit 947a92acf7cfef8744b28ae65695410a28179b52 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T04:36:23Z chore: Add license to newly created java files commit 297733f196aac4f0cec1077b8d6ec7a5deb09220 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T14:10:37Z fix: Modify github-markdown-css license - move the license file from `bin_license/` to `license/` - extract source code from `interpreter.css` to clarify - add css description to `markdown.css` like `font-awesome.min.css` commit 85a5e3ac8cac3e98d1f71413ddf47b57150d1dd7 Author: 1ambda <1am...@gmail.com> Date: 2016-09-05T08:15:28Z fix: Use bower to install github-markdown-css commit 4d1cb3cb989cc1ef31fef9f0bca6f5a5f9fb0355 Author: 1ambda <1am...@gmail.com> Date: 2016-09-05T14:32:40Z fix: Typo in docs/interpreter/markdown.md commit 8b1e0170aa0964c26656aa126a67f417b78678bd Author: 1ambda <1am...@gmail.com> Date: 2016-09-07T15:17:33Z chore: Move github-markdown-css license to bin_licenses commit e08929a093f6b85df2a7f2137cda2dc205433512 Author: 1ambda <1am...@gmail.com> Date: 2016-09-07T15:24:49Z fix: Handle more specific exception in catch block commit e6d41c8a92d27ca87ee83f4c5479c848d59c45e0 Author: 1ambda <1am...@gmail.com> Date: 2016-09-20T15:23:27Z fix: Resolve merge conflict with 8f344db commit 16cda72ca3f36f10238bbfc2d578f6e1469fc728 Author: 1ambda <1am...@gmail.com> Date: 2016-09-21T01:20:58Z fix: Merge with 3c8158 to resolve CI failure ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---