GitHub user vectorijk opened a pull request:

    https://github.com/apache/zeppelin/pull/1530

    [Zeppelin-1555] Eliminate prefix in PythonInterpreter exception

    ### What is this PR for?
    Solve bug metioned 
[here](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L139)
    
    Since we launch python interpreter as a process and redirect stdin and 
stdout, only exception occurred (like syntax error or indentation error, etc) 
could give string like `...`. Thus, we don't need to determine whether syntax 
error happened in 
[`PythonProcess.sendAndGetResult`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonProcess.java#L86)
 because we have detected error in 
[`PythonInterpreter.pythonErrorIn`](https://github.com/apache/zeppelin/blob/3dec4d7006b8a57136f34ae330ba937d8990f2d2/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L152)
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    Jira: https://issues.apache.org/jira/browse/ZEPPELIN-1555
    ### How should this be tested?
    Test locally.
    
    ### Screenshots
    <img width="1175" alt="screen shot 2016-10-16 at 18 05 00" 
src="https://cloud.githubusercontent.com/assets/3419881/19422552/192a8b3a-93cb-11e6-89e8-63f2652a7f85.png";>
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vectorijk/zeppelin zeppelin-1555

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1530
    
----
commit d7a2ef4003c717141003aa94f7c28a529a1db390
Author: Kai Jiang <jiang...@gmail.com>
Date:   2016-10-17T00:54:11Z

    [zeppelin-1555] Eliminate prefix in PythonInterpreter exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to