Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1522
@kjhong
The changes looks good to me, but here are few suggestions from my side.
* Felt that the Description field need to be editable. How about displaying
in a textArea?
* How about Storing the description as a separate set of key value pairs ?
so that it is completely readable.
For ex:
Currently **after your changes,** the json might look like
_"properties": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
"hdfs.maxlength-description": "1000",
"hdfs.user-description": "hdfs",
},_
Instead if we store them as a different set of key value pairs the json
might look like,
_"properties": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
},
and
"properties-description": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
},_
which will be more readable and straight forward.
From **future changes** perspective, this will benefit us when
* There is an additional field getting added other than description
* When someone is calling the restApi (createInterpreter) of this via tools
like postman the datastructure will be clearly defined and easy to use instead
of complicating the values inside the same properties datastructure.
Let me know your views on these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
