GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1540
[WIP][ZEPPELIN-1566] Make paragraph editable with double click
### What is this PR for?
This PR enables edit on double click for markdown/angular paragraph. Users
can change `editOnDblClick` field to be `false` by editting
`interpreter/md/interpreter-setting.json` or `conf/interpreter.json`. In the
same context, users can set other type paragraphs to be editable on double
click by setting `editOnDblClick` to be true.
This PR also fixes bug that syntax highlight doesn't work on pasted code.
### What type of PR is it?
Feature
### Todos
* [ ] Create test
* [ ] Update docs
### What is the Jira issue?
[ZEPPELIN-1566](https://issues.apache.org/jira/browse/ZEPPELIN-1566)
### How should this be tested?
1. Create new markdown interpreter
2. Create notebook and run markdown paragraph
3. Double click markdown paragraph to edit
### Screenshots (if appropriate)
**Edit on double click and hide editor on paragraph run**
**Syntax highlight on paste**
Before
After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1566
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit b6720c097f2ffd53a808ae5aead5605f996bb2c8
Author: Mina Lee <[email protected]>
Date: 2016-10-19T08:41:14Z
Split getAndSetEditorSetting method into getEditorSetting and
setEditorLanguage method
commit e934aaee4ccdc406a6dfa27491a6a386bcd4cca9
Author: Mina Lee <[email protected]>
Date: 2016-10-20T03:17:02Z
Make paragraph editable on doubleclick if editOnDblClick set true in
interpreter-setting.json
commit 41f6a92dd88fafc555f4a2102bae1d98cdd9498f
Author: Mina Lee <[email protected]>
Date: 2016-10-20T03:54:08Z
Add editOnDblClick field in interpreter-setting.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
