GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/1586

    [hotfix] does not showing notebooklist on navbar

    ### What is this PR for?
    Currently, if you enabled for shiro then
    not showing notebook list on navbar.
    (If you refresh, it's well viewwing.)
    i resolve this problem.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    - [x] fixed a bug ( navbar.controller.js)
    - [x] added testcase
    
    ### How should this be tested?
    1. endabled shiro (per user login)
    2. login.
    3. on click to notebook menu on navbar.
    
    ### Screenshots (if appropriate)
    #### before
    
![navbar_pr](https://cloud.githubusercontent.com/assets/10525473/19957865/b112d8c4-a1dd-11e6-9f0c-363919b321d8.png)
    
    #### resolve after (on this pr)
    
![correct](https://cloud.githubusercontent.com/assets/10525473/19957885/d487ad16-a1dd-11e6-81b0-ebd210bd6f98.png)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin 
ZEPPELIN-NOTEBOOKLIST-SHIRO

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1586
    
----
commit 27451a410897f5e60276e8eb77e1b0662e0d037f
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-11-02T10:15:40Z

    bug fixed can't load for notebook list when enabled shiro

commit 72ff950b0772ff7b3c0f569ea5162cec93440c97
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-11-03T04:34:23Z

    fixed notebook list count testcase in AuthIT

commit 0378d76229a52b64066b90c8f56ceb109b07d202
Author: CloverHearts <cloverhearts...@gmail.com>
Date:   2016-11-03T06:29:13Z

    fixed test case throws exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to