Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1598
  
    @bbonnin Thanks for the quick review :) 
    
    1. Duplicated code in `executeDeleteQuery` is due to incompatible API 
between 2.x and 5.x 
    
    ```
    // 2.x
    public boolean isFound() { ... } 
    // 5.x
    RestStatus.NOT_FOUND != response.status())
    ```
    
    But we can extract duplicated validation logic to the base class as you 
mentioned.
    
    2. @bzz, @bbonnin  Regarding to update docs, 
    
    Are there more files I should update? I am asking because 
    
    - new maven profile is added `elasticsearch-2` (activated by default), 
`elasticsearch-5`
    - `elasticsearch-5` profile requires java 8 +
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to