GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1625
[ZEPPELIN-1657] Private/public mode for user note creation/import
### What is this PR for?
In multi-user environment when users create a notebook normally they would
expect that notebook be listed only in their list/workbench. Currently Zeppelin
creates/imports notes as public by default. There should be at least a way to
pass through configuration to make this behaviour private be default. Should
discuss whether it's public or private by default.
### What type of PR is it?
Improvement
### Todos
* [x] - set permissions on create/import
* [x] - test
* [ ] - review, feedback, decide whether public/private by default
* [ ] - pass through `zeppelin-env.sh` as well?
### What is the Jira issue?
[ZEPPELIN-1657](https://issues.apache.org/jira/browse/ZEPPELIN-1657)
### How should this be tested?
1. set `zeppelin.notebook.public` property as false in `zeppelin-site.xml`
2. login as user1 and create noteA, note should appear in your list of notes
3. logout and login as user2, shouldn't be able to see noteA
### Screenshots (if appropriate)
TBD
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/public-note-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1625
----
commit 09b23e150c3014b93def4039a63ba61fd4ee0d3b
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-11T09:13:18Z
add property to site.xml
commit 0c691b23f76d9c62f1230437510779fdacfa5253
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-11T10:03:54Z
add var to env.sh
commit 610ada94eba51efba5b6f607895f779e3f207027
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-11T10:52:23Z
add variable to ZeppelinConfiguration
commit bebe6be809cd6566e3de334c9b9d5585bb5596ae
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-13T13:15:13Z
set new note permissions
commit cf2acb0e11d253f894e6d78f3dda2bb1f20e4db7
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-13T13:15:51Z
set permissions on note create and import
commit c7faeee18836c99758e1eb214843844074dda301
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-13T16:57:51Z
read env var from conf file directly
commit fb44fd7af06558a88356544131fc9c8f10696330
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-13T16:58:04Z
add test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
