Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1639
  
    Thank you for good effort and contribution @felizbear ! 
    
    Please, expect that usually reviews do take some time. 
    
    One thing that @1ambda brought that would be nice to understand better - 
it's impact on build time, esp on CI. If somebody could post before\after 
information on the PR description, that would be very interesting.
    
    Just skimmed through the changes and they look good, will test more 
tomorrow.
    
    On CI, I w: @tae-jun @felizbear @1ambda  it usually helps committers to 
analyze the failure much faster if somebody posts the summary to the PR itself 
like: 
     - which profile failed
     - what is the reason (search for "exited with 1" in raw logs)
    
    I.e right now for `Scala 2.11, Hadoop 2.0` we have
    
    ```
    [INFO] Zeppelin: Server ................................... SUCCESS [ 
12.892 s]
    [INFO] Zeppelin: Packaging distribution ................... SKIPPED
    ...
    [INFO] 
------------------------------------------------------------------------
    [ERROR] Java heap space -> [Help 1]
    [ERROR] 
    ```
    
    And for Integration Tests it seems that we have a candidate for a new JIRA 
issue with `flaky-tests` label
    ```
    
    Results :
    
    Tests in error: 
      ParagraphActionsIT.testEditOnDoubleClick:443 » ElementNotVisible Element 
is no...
    
    Tests run: 17, Failures: 0, Errors: 1, Skipped: 0
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to