Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1647
@Mleekko
Thanks for contribution.
A. CI failure is not related to this PR
```
// https://api.travis-ci.org/jobs/176444213/log.txt?deansi=true
17:44:25,594 ERROR org.apache.zeppelin.search.LuceneSearch:120 - Failed to
open index dir RAMDirectory@7e1ec70e
lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@169ea8d2, make
sure indexing finished OK
org.apache.lucene.index.IndexNotFoundException: no segments* file found in
RAMDirectory@7e1ec70e
lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@169ea8d2: files:
[]
at
org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:726)
at
org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:50)
at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63)
at org.apache.zeppelin.search.LuceneSearch.query(LuceneSearch.java:104)
at
org.apache.zeppelin.search.LuceneSearchTest.canNotSearchBeforeIndexing(LuceneSearchTest.java:147)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
17:44:25,606 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2
notebooks took 7ms
17:44:25,653 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2
notebooks took 5ms
17:44:25,704 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2
notebooks took 5ms
```
B. However, making CI green is good usually. Since reviews may not see a
failed PR because of many PRs
There are 2 ways to trigger CI again
- (clean way) commit --amend and push HEAD --force
- (easy, but not clean way) close PR and reopen
C. Let me review and return some feedbacks. Thanks again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
