GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1711
[ZEPPELIN-1721] Let each visualization define 'setting'.
### What is this PR for?
ZEPPELIN-1003 made an abstraction layer for visualization and now
visualizations are moved to [zeppelin-web/src/app/visualization/builtins]
https://github.com/apache/zeppelin/tree/master/zeppelin-web/src/app/visualization/builtins
from single monolithic place `paragraph.controller.js`.
However, 'setting' of each visualizations (i.e. pivot keys, groups, values
selection, column selection in scatter chart, etc) are still in
paragraph.controller.js and it's html template is hardcoded.
This PR lets each visualization implement their own 'setting' and provide
facilities to store/load configs for it.
### What type of PR is it?
Improvement
### Todos
* [x] - Make each visualization provides setting template
* [x] - load / save configs for the setting
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1721
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1721
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1711
----
commit 3d409c7ae9161169edfff3e9cd0c895980467c7c
Author: Lee moon soo <[email protected]>
Date: 2016-11-27T19:58:30Z
abstract transformation setting and apply scatter chart
commit 69bb986e901d94008a76806ecc08fe51ff5856d6
Author: Lee moon soo <[email protected]>
Date: 2016-11-28T20:29:45Z
Abstract pivot setting
commit 7470578bbef7e2be1b53ae922f412edd7abe616e
Author: Lee moon soo <[email protected]>
Date: 2016-11-28T20:38:09Z
merge unnecessarily scattered html templates
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
