GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1725
[MINOR] Resolve bower dependency conflict, hang (zeppelin-web)
### What is this PR for?
Due to angular dependency conflict, `bower install` command doesn't proceed
further. It causes the whole build fail. (even in local)
```
62 silly postinstall [email protected]
/Users/jl/local/src/g/zeppelin/zeppelin-web/zeppelin-web-cca93801
63 info lifecycle [email protected]~postinstall: [email protected]
64 verbose lifecycle [email protected]~postinstall: unsafe-perm in
lifecycle true
65 verbose lifecycle [email protected]~postinstall: PATH:
/Users/jl/local/src/g/zeppelin/zeppelin-web/node/node_modules/npm/bin/node-gyp-bin:/Users/jl/local/src/g/zeppelin/zeppelin-web/node_modules/.bin:/Users/jl/local/src/g/zeppelin/zeppelin-web/node:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:
66 verbose lifecycle [email protected]~postinstall: CWD:
/Users/jl/local/src/g/zeppelin/zeppelin-web
67 silly lifecycle [email protected]~postinstall: Args: [ '-c', 'bower
install --silent' ]
68 silly lifecycle [email protected]~postinstall: Returned: code: 1
signal: null
69 info lifecycle [email protected]~postinstall: Failed to exec
postinstall script
70 verbose stack Error: [email protected] postinstall: `bower install
--silent`
70 verbose stack Exit status 1
70 verbose stack at EventEmitter.<anonymous>
(/Users/jl/local/src/g/zeppelin/zeppelin-web/node/node_modules/npm/lib/utils/lifecycle.js:255:16)
70 verbose stack at emitTwo (events.js:106:13)
70 verbose stack at EventEmitter.emit (events.js:191:7)
70 verbose stack at ChildProcess.<anonymous>
(/Users/jl/local/src/g/zeppelin/zeppelin-web/node/node_modules/npm/lib/utils/spawn.js:40:14)
70 verbose stack at emitTwo (events.js:106:13)
70 verbose stack at ChildProcess.emit (events.js:191:7)
70 verbose stack at maybeClose (internal/child_process.js:877:16)
70 verbose stack at Process.ChildProcess._handle.onexit
(internal/child_process.js:226:5)
71 verbose pkgid [email protected]
72 verbose cwd /Users/jl/local/src/g/zeppelin/zeppelin-web
73 error Darwin 16.1.0
74 error argv "/Users/jl/local/src/g/zeppelin/zeppelin-web/node/node"
"/Users/jl/local/src/g/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js"
"install"
75 error node v6.9.1
76 error npm v3.10.8
77 error code ELIFECYCLE
78 error [email protected] postinstall: `bower install --silent`
78 error Exit status 1
79 error Failed at the [email protected] postinstall script 'bower install
--silent'.
79 error Make sure you have the latest version of node.js and npm installed.
79 error If you do, this is most likely a problem with the zeppelin-web
package,
79 error not with npm itself.
79 error Tell the author that this fails on your system:
79 error bower install --silent
79 error You can get information on how to open an issue for this project
with:
79 error npm bugs zeppelin-web
79 error Or if that isn't available, you can get their info via:
79 error npm owner ls zeppelin-web
79 error There is likely additional logging output above.
80 verbose exit [ 1, true ]
```
##### Small Details
you can get this `resolutions` field by executing `bower install --force`
```
"resolutions": {
"angular": ">=1.2.15 <1.6"
}
```
but we are using angular 1.5.0+ the resolution will cause errors like
```
[INFO] undefined
ERROR: 'Error: [$injector:unpr] Unknown provider:
$$forceReflowProvider <- $$forceReflow <- $$animateQueue <- $animate <-
$compile <- $$animateQueue
[INFO]
http://errors.angularjs.org/1.4.3/$injector/unpr?p0=%24%24forceReflowProvider%20%3C-%20%24%24forceReflow%20%3C-%20%24%24animateQueue%20%3C-%20%24animate%20%3C-%20%24compile%20%3C-%20%24%24animateQueue
...
[INFO] PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 69 of 69 (34 FAILED)
(0.236 secs / 0.269 secs)
[INFO] Warning: Task "karma:unit" failed. Use --force to continue.
```
So we need to specify 1.5.0 as the min angular version
### What type of PR is it?
[Bug Fix | Hot Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
Minor
### How should this be tested?
CI will do that :)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin hotfix/resolve-bower-hangs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1725
----
commit 2b3d52dd8e3e86426e7be04b12dc6a9ac6e3de32
Author: 1ambda <[email protected]>
Date: 2016-12-04T11:37:46Z
fix: Resolve bower install hangs
commit 533c5a3ebdffbffc3b09f979272dae93fc1f49d2
Author: 1ambda <[email protected]>
Date: 2016-12-04T12:08:30Z
fix: Use 1.5.0 min angular version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
