GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in
paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most
functions in paragraph controller to accept explicit parameters instead of
getting data from `$scope`. It is a first - simple and safe - step in making
paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <[email protected]>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <[email protected]>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <[email protected]>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <[email protected]>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <[email protected]>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <[email protected]>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <[email protected]>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <[email protected]>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <[email protected]>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <[email protected]>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <[email protected]>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <[email protected]>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <[email protected]>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <[email protected]>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <[email protected]>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <[email protected]>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <[email protected]>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <[email protected]>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <[email protected]>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <[email protected]>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <[email protected]>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <[email protected]>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <[email protected]>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <[email protected]>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <[email protected]>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <[email protected]>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <[email protected]>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 4070c84a99c5e578c03e611d2e8232e52b393c1f
Author: felizbear <[email protected]>
Date: 2016-12-05T11:17:57Z
fix test
removed unsuded toggleGraphOption
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
