Jeff Zhang created ZEPPELIN-1785:
------------------------------------

             Summary: Clarify where to pick up ZeppelinConfiguration
                 Key: ZEPPELIN-1785
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1785
             Project: Zeppelin
          Issue Type: Bug
    Affects Versions: 0.7.0
            Reporter: Jeff Zhang
            Assignee: Jeff Zhang


The current issue I found is that zeppelin.notebook.dir defined in 
zeppelin-site.xml doesn't take effect. Because we define it in 
https://github.com/apache/zeppelin/blob/master/bin/common.sh#L52 and 
ZeppelinConfiguration will pick up configugration through enviroment variable 
by first. I think some other conf like zeppelin.interpreter.dir are the same. 

There're 2 solutions for it. 
* Remove them in common.sh 
* Preferer property in zeppelin-site.xml over enviroment variable. 

Personally, I prefer the second solution.  As I think property is easier to 
understand, and we should use zeppelin-site as central place for all the 
configurations. This is also the approach what spark use.
\cc [~moon] [~luciano resende] [~anthonycorbacho] [~jongyoul]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to