GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1694
[ZEPPELIN-1718] Prevent anonymous user to set note permission
### What is this PR for?
Currently anonymous user can open the notebook permission page and type sth
in `Owner`/ `Reader` / `Writer` and then even can save it. However, in fact, it
doesn't work actually.
e.g. An anonymous user can type `admin` / `user1` to the note permission
setting fields.
It doesn't make sense. At least we should disallow the non-authenticated
users(a.k.a anonymous users) by deactivating those permission related
features(will handle interpreter user setting in another PR). So what I did in
this PR is
- Hide note authorization setting fields with notice sentence in dialog &
add related docs link:
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/notebook_authorization.html
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
[ZEPPELIN-1718](https://issues.apache.org/jira/browse/ZEPPELIN-1718)
### How should this be tested?
### Screenshots (if appropriate)
- Doesn't show note permission setting page & show warning dialog if
anonymous user tries to click lock icon
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin prevent-anon-user
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1694.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1694
----
commit 06c632641afcddf57d1b1a15248876c88fbbb8fe
Author: AhyoungRyu <[email protected]>
Date: 2016-12-18T16:00:21Z
Block anonymous user to set the note permission
commit b59771c0bfa44c352c6d2044599063a93f48a227
Author: AhyoungRyu <[email protected]>
Date: 2016-12-18T16:35:36Z
Remove useless div block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
