[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1791

    [ZEPPELIN-1847] fix: Copy only html when html file changed

    ### What is this PR for?
    
    Reduce build time by avoiding to copy non-related files. Approx 3~4 secs as 
you can see below.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    Nothing
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1847](https://issues.apache.org/jira/browse/ZEPPELIN-1847)
    
    ### How should this be tested?
    
    1. `cd zeppelin-web`
    2. `npm install` && `npm run start`
    3. change any html file in `src/` and see log. 
    4. compare the result with master branch's
    
    ### Screenshots (if appropriate)
    
    
    ```
    Running "watch" task
    Waiting...
    >> File "src/app/home/home.html" changed.
    
    
    ## before
    
    Execution Time (2016-12-22 08:13:35 UTC)
    loading tasks   130ms  ▇▇▇ 3%
    htmlhint:src     84ms  ▇▇ 2%
    newer:copy:dev   3.6s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
 93%
    Total 3.9s
    Completed in 5.953s at Thu Dec 22 2016 17:13:39 GMT+0900 (KST) - Waiting…
    
    ## after
    
    Execution Time (2016-12-22 08:14:27 UTC)
    loading tasks       137ms  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
 52%
    newer:htmlhint        3ms  ▇ 1%
    newer:htmlhint:src   25ms  ▇▇▇▇▇▇▇ 10%
    htmlhint:src         89ms  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 34%
    newer:copy:html       5ms  ▇▇ 2%
    Total 261ms
    
    Completed in 2.447s at Thu Dec 22 2016 17:14:27 GMT+0900 (KST) - Waiting…
    ```
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin fix/DONT-copy-all-files-grunt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1791.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1791
    
----
commit 03e95f778ddd2d6a13c279a85ff14aa3616b8f05
Author: 1ambda <1am...@gmail.com>
Date:   2016-12-22T08:29:30Z

    fix: Copy only html when html file changed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---