GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1775
[ZEPPELIN-1745] View revisions in non-editable mode
### What is this PR for?
This is to make view of revisions non-editable
### What type of PR is it?
Improvement
### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys
### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)
### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to
modify note
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/revision-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1775
----
commit 4c838954d38f13a6714fe9c460687e66bf92f16c
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T04:20:22Z
change var name revisionDisabled -> revisionView
commit fa1397df6d0fcc469d09bb86c223e7b2bd1d007a
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:10:26Z
disable run all
commit 8e978005f99ac1120db08abfe759f3654c3bf846
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:12:09Z
disable clear output
commit 46238e8395ed93c4db5de575223319f4a604f6c3
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:18:02Z
disable clone note
commit 50d40ad2af176e029ba31426065e230c41048c25
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:19:21Z
disable export note
commit 5d9f877722211fcf96482f36c909855bef6936e6
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:22:14Z
disable revision commit
commit ab8ab4db37d6d374b18bc9590f13f96bd1c58bf8
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:24:16Z
disable remove note
commit 711c0b325d07f36ece5ed1ab78d086b975bdcbc4
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-16T08:25:42Z
disable scheduler
commit 7d115b821f0734dfb361d1018c0e60b0e7d6d157
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T04:21:51Z
disable + new paragraph
commit 19cacbd6116342dd5e11f63eac419b557554df9e
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T04:26:37Z
don't show paragraph settings menu
commit c55de951adaaaa0ee97d16530465e3dae1651679
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T05:09:27Z
don't show run/cancel on paragraph
commit 00fb556059d561d986b4c4d2ef054f7f79e7d6b7
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-19T08:00:39Z
make paragraph title non-editable
commit 9b85e05e0ffc03653d64984d6e27f283b7b0e4fc
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T05:20:07Z
disable editor editing
normally it should be done on change of .revisionView however at that time
editor isn't loaded yet
commit 7751b69f28d5113226fb36caff6becdb985cfb22
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:11:50Z
disable hotkeys
commit 81346e9313b2e5c7d5b1bd205df3d2000ffe9dfb
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:32:15Z
disable editing note name
commit 0946377d72f2dd2bdcec63b425396d2b2c965701
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:41:34Z
disable show/hide code in note action-bar
commit 46d67af60eab15099a22950e6e191995f92fcc34
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:43:20Z
disable show/hide output in note action bar
commit 1eea8ce1437e9d8232991c8a236ed911bdfe6cbe
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:47:25Z
don't show paragraph level hide editor button
commit aff02b95e1b42a9d5031e6f20e28a95e0adebab8
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-20T06:48:13Z
don't show paragraph level hide output buttton
commit e9d3ceb59136e7d51b1bb17b8574e18faa507c9d
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-27T07:07:11Z
disable edit on db click md interpreter
commit 4bfe5605deb7bc6d024ba2cbc6bed6ae3d850451
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T06:18:31Z
gray out editor on revision view
commit 2823142ac018cfe7f7ac85a9871e5b2072cfb384
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T12:45:01Z
add group span for ng-if
commit 06e2977de8fb0bc0e0b3981c1eac076ca4bfad04
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T12:47:07Z
check newValue for undefined
commit 1a5a6a7b74d7c8634237b9d2de04df2784cd1b28
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T15:50:55Z
render result change without commit
commit fa05bdb274bb88d7cddb36f11f3d94e33df37b4d
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T16:23:07Z
Merge branch 'master' into feat/revision-view
commit 84d2c5abe77a0e9e3695338dcafe38f5594be7e3
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-29T17:03:56Z
disable personalized mode button
commit 843abf4d73746fff8213cf3b4f1b5b9d4d1917e1
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-30T05:54:07Z
remove escaped single quote inside console
was failing to build, problem with removing console messages for prod
commit b3a78c77fb04eaddab06692836787342656de50a
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-30T22:05:25Z
dont show bingings, perms, hotkeys
commit efe09c08268a1df6a3013087cff7f18d5766a61d
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-31T05:42:42Z
enable report view without save
commit bbaf286d60a07d4f5f7dd7a55e0f836ab116507d
Author: Khalid Huseynov <[email protected]>
Date: 2017-01-01T21:13:22Z
initialize looknfeel
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
