[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

[soralee]

GitHub user soralee reopened a pull request:

    https://github.com/apache/zeppelin/pull/1834

    [ZEPPELIN-1864] Improvement to show folder and note after searching note

    ### What is this PR for?
    This PR is for improvement to show folder and note after using the filter. 
And I found some bugs and fixed like this.
    
    the following list is improvement and bug fixed.
    1. After using the filter in Zeppelin Home, every note is shown by the form 
[FolderName/NoteName] like below. It would be nice to show folder icon and note 
icon as previous status.
    
![z1864_f_b](https://cloud.githubusercontent.com/assets/8110458/21604777/79dbb228-d1e8-11e6-974d-737520729d68.gif)
     
    2. When using the filter, some functions and icons next to note and folder 
are disappeared.
    
![z1864_f_2_b](https://cloud.githubusercontent.com/assets/8110458/21605057/f5a0143e-d1e9-11e6-86f3-ebff5be4c41d.gif)
    
    3. When using the filter, the `Rename Note` function doesn't work. ( When I 
was handling this PR, this bug was discovered.)
    
![z1864_f_4_b](https://cloud.githubusercontent.com/assets/8110458/21606384/71305796-d1f2-11e6-91a4-2ec14b8b4959.gif)
    
    
    ### What type of PR is it?
    [ Bug Fix | Improvement ]
    
    ### Todos
    * [x] - improve to show folder and note when finishing to use filter.
    * [x] - some functions and icons next to note and folder are appeared when 
using filter.
    * [x] - fix `Rename Note` function when using the filter.
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1864
    
    ### How should this be tested?
     - **[Test 1]** Before/After using the filter, check the list structure of 
your notes. It should be same appearance.
    
     - **[Test 2]** When using the filter, check the notes. Some icons and 
functions next to note and folder should be appeared.
    
     - **[Test 3]** When using the filter, click `Rename Note`. It should be 
appeared the path of Note.
    
    ### Screenshots (if appropriate)
    **Test 1**.
    
![z1864_f_1_a](https://cloud.githubusercontent.com/assets/8110458/21606849/a79dbf82-d1f5-11e6-8d48-3a1977099ab1.gif)
    
    **Test 2**.
    
![z1864_f_2_a](https://cloud.githubusercontent.com/assets/8110458/21606880/d1cf9550-d1f5-11e6-9311-ee54424d7e76.gif)
    
    **Test 3**.
    
![z1864_f_4_a](https://cloud.githubusercontent.com/assets/8110458/21606272/9e0b096a-d1f1-11e6-8bfb-ab1ea1a30b88.gif)
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1834
    
----
commit 93c4b6b17cdfa6bfde7ac000f7743971f41b7640
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-03T09:35:55Z

    Improvement to show folder and note after searching note

commit b11ec620ddf44c0c76f2e61e7db7fa1d9a69e755
Author: soralee <sora0...@nflabs.com>
Date:   2017-01-03T11:51:31Z

    Improvement to show folder and note after searching note

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---