GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/1860

    [ZEPPELIN-1848] add option for S3 KMS key region

    ### What is this PR for?
    When using S3 storage layer with encryption keys, currently only keys 
created in `us-east-1` region can be used. This PR adds ability to set target 
region for AWS KMS keys.
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - add region to awsClient 
    * [x] - add conf for region
    * [x] - tested with aws account `us-west-2` region
    
    ### What is the Jira issue?
    [ZEPPELIN-1848](https://issues.apache.org/jira/browse/ZEPPELIN-1848)
    
    ### How should this be tested?
    1. set up S3 storage as in 
[here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)
    2. add region variable with `export 
ZEPPELIN_NOTEBOOK_S3_KMS_KEY_REGION="us-west-2"` in `conf/zeppelin-env.sh`
    3.  start Zeppelin and read/write S3
    
    ### Screenshots (if appropriate)
    
![kmc_region](https://cloud.githubusercontent.com/assets/1642088/21712912/0a79ee66-d3ac-11e6-8ba4-1e7f081f213f.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? updated


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/s3-repo-kms-region

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1860
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to