GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/1849
[ZEPPELIN-1902] Fix blank default intp select box after Zeppelin started
when Shiro on
### What is this PR for?
After #1520 we can set default interpreter when we create new note.
Currently this feature is implemented to get `interpreterSetting` list when
Zeppelin is initiated (can be checked in dev console). And it needs user's
info. So there can be two cases like below.
- Shiro off
It tries to get interpreter setting lists as `anonymous` user
In this case, the problem is not happened. If we don't turn Shiro on, it
doesn't need user's info and Zeppelin automatically creates fake user(?) info
as `anonymous`. So there is no problem to get the interpreter setting lists.
- Shiro on
tries to get interpreter setting lists as ' ' user since we're not
loggined yet.
So it's failed to get interpreter setting lists since it doesn't have any
user info. It needs reloading to get it.
Actually we don't need to send `GET_INTERPRETER_SETTINGS` msg when Zeppelin
started. It would be fine when we click "Create new note" button. So I removed
`init()` (it's used only for getting interpreter settings) and made
`getInterpreterSettings` called only when user clicks "Create new note" in both
Zeppelin home and Navbar.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
[ZEPPELIN-1902](https://issues.apache.org/jira/browse/ZEPPELIN-1902)
### How should this be tested?
In master (not this branch)
1. [Turn Shiro
on](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#1-enable-shiro)
and start(restart) Zeppelin
2. Click "Create new note" in home (or Navbar)
3. the default interpreter select box will be like
but it'll be okay after reloading. It shouldn't be like that with this
patch.
### Screenshots (if appropriate)
after fixing this problem
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1902
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1849.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1849
----
commit 30909338de44eef0171a00b4377b54a2acd94852
Author: AhyoungRyu <[email protected]>
Date: 2017-01-05T10:38:21Z
Fix blank default intp select box after Zeppelin started when Shiro on
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
