[GitHub] zeppelin pull request #1870: [ZEPPELIN-1924] Fix "this._isNumeric is not a f...

[AhyoungRyu]

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1870

    [ZEPPELIN-1924] Fix "this._isNumeric is not a function" error 

    ### What is this PR for?
    After #1815 was merged, 
    ```
    uncaught TypeError: this._isNumeric is not a function
        at ColumnSettings._numericValidator [as validator] 
(handsonHelper.js:172)
        at handsontable.js:5181
    ```
    is shown when click "Numeric" in the result table like below. 
    <img 
src="https://cloud.githubusercontent.com/assets/10060731/21749365/d1d700ee-d5e0-11e6-9f25-65ebb3ea313a.gif";
 width="450px">
    
    Since ES6 no longer supports autobind for `this`, seems it needs to be 
bound in the constructor.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1924](https://issues.apache.org/jira/browse/ZEPPELIN-1924)
    
    ### How should this be tested?
    **To reproduce**
    In master, go to Spark tutorial note and click 
    <img width="230" alt="screen shot 2017-01-08 at 8 32 05 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/21749412/8a123318-d5e1-11e6-9a65-a84e443c385c.png";>
 
    `Numeric`. Then the error msg will be shown in browser dev console. 
    
    With this patch, this error msg won't be shown up anymore :)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1924

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1870
    
----
commit 7d5bf9ee46122f6e5c3b0c00c948b533d63f2b4d
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-01-08T11:23:34Z

    Bind _numericValidator in the constructor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---