GitHub user robbinspg opened a pull request:

    https://github.com/apache/zeppelin/pull/1894

    [ZEPPELIN-1560] avoid generating minus sign in package name

    ### What is this PR for?
    using Object.hashCode() as part of the REPL wrapper class name can cause a 
compilation error as hashCode can validly return a negative integer.
    
    We would like this fix backported to 0.6 and later streams.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1560
    
    ### How should this be tested?
    regression tests with openJdk + tests with IBM jvm
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO 
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robbinspg/zeppelin ZPPELIN-1560

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1894
    
----
commit eeef3ad48f676da6be2248a9d6475ceb0db38917
Author: robbins <robb...@uk.ibm.com>
Date:   2017-01-12T15:15:29Z

    [ZEPPELIN-1560] avoid generating minus sign in package name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to