[GitHub] zeppelin issue #1940: [ZEPPELIN-2008] Introduce Spell

[1ambda]

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1940
  
    rebased to resolve conflict with master.
    
    @Leemoonsoo Thanks for detailed review! I updated code according to your 
comment.
    
    (1) **Couldn't make Spell as display system work:** Let's handle in 
following PRs.
    
    originally, i meant "we can use spell display with backend interpreter **if 
we modify some backend code**". Sorry for confusing. I tried to fix it in this 
PR, but it's not that easy as i expected since current `InterpreterResult.Type` 
is enum, not string. IMO, it can be handled in following PRs. (I modified this 
PR description too)
    
    - 
https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterOutput.java#L225
    
    (2) **Configuring Display order of Spell doesn't make sense**: Fixed.
    
    (3, 4) **Display keyword of the spell**, **Example for example spells** 
    
    Now `#/helium` page displays `spell.magic`, `spell.usage` which are saved 
helium package json.
    
    <img width="707" alt="screen shot 2017-01-30 at 9 32 42 am" 
src="https://cloud.githubusercontent.com/assets/4968473/22409610/b00f928c-e6cf-11e6-9035-8692cc32e345.png";>
    
    ```
    {
      "type" : "SPELL",
      "name" : "translator-spell",
      ...
      "spell": {
        "magic": "%translator",
        "usage": "%translator <source>-<target> <access-key> <TEXT>"
      }
    }
    ```
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---