GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1804
[ZEPPELIN-1578] notes list in customizing zeppelin homepage isn't working
### What is this PR for?
Customizing the Zeppelin Homepage to show the notebook list does not work
as [0.6.2
document](http://zeppelin.apache.org/docs/0.6.2/manuala/notebookashomepage.html#show-notebooks-list-in-your-custom-homepage).
Furthermore, it is not working on 0.7.0 version ([0.7.0
document](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/notebookashomepage.html#show-notes-list-in-your-custom-homepage)).
That reason is that get_home message of zeppelin websocket is called in
zeppelin-web twice.
At this chance, I suggest to split role to HomeCtrl and CustomHomeCtrl
because when "Home.controller.js" is update, It could be conflicted like
current issue.
So I think it would be more convenient to manage the roles separately.
### What type of PR is it?
[Bug Fix | Feature | Documentation ]
### Todos
* None
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1578
### How should this be tested?
- After write the following code in paragraph, run it.
```
println(
"""%angular
<div ng-include="'app/home/notebook.html'"></div>
""")
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1804.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1804
----
commit 58d08f8daa65384c614c51c61bc7e9301c35f48d
Author: soralee <[email protected]>
Date: 2016-12-23T06:36:53Z
notes list in custom homepage isn't working
commit cad590f49e3e015851860929ad0dff4e0c15fec1
Author: soralee <[email protected]>
Date: 2016-12-27T11:15:16Z
fix to show text after searching note
commit b836354e73cad1ad2b46b03c2cd11d46131e8363
Author: soralee <[email protected]>
Date: 2016-12-29T08:14:18Z
rebase master
commit f77a32ccbe8b94a53f8494dbae9829191735a454
Author: soralee <[email protected]>
Date: 2017-01-10T03:39:59Z
improve customer hompage
commit f7e6bc6278d4da7887a6823103e1dd068c0d6b52
Author: soralee <[email protected]>
Date: 2017-01-10T03:49:26Z
remove file
commit f4917eb6f60c5bf2fac6a774c03a0cfd920b432c
Author: soralee <[email protected]>
Date: 2017-01-10T03:53:49Z
remove old img file
commit b93378460f21518b14dc4171f98d6e61425dc35e
Author: soralee <[email protected]>
Date: 2017-01-10T04:16:39Z
apply homepage template
commit d18e513afcc81347d4db1b181e8bae005fd944c4
Author: soralee <[email protected]>
Date: 2017-01-10T05:04:55Z
for rebase it
commit 229ed372c3a47a132b27a7fb78c315dab16cf83c
Author: soralee <[email protected]>
Date: 2017-01-10T10:15:20Z
bug fix
commit 55b7ddc2542ed6318ee33782d5d0d6b42fc0b37d
Author: soralee <[email protected]>
Date: 2017-01-11T03:37:16Z
resolve conflict
commit 028f873a453607a4ef5579870c6827f77f26c626
Author: soralee <[email protected]>
Date: 2017-01-12T04:01:05Z
resolve conflict
commit 473bce4fc6c4d1a4e7dd51c8821a8288be737817
Author: soralee <[email protected]>
Date: 2017-01-12T05:33:23Z
using home-template both home.html and customHome.html
commit a9036a8b3c47559fe578eea60cad73a9b4eee5c5
Author: soralee <[email protected]>
Date: 2017-01-27T12:38:23Z
rename files
commit e752e4815bfaa6cf07f96dcdd54d89b056c5a9bc
Author: soralee <[email protected]>
Date: 2017-01-27T13:03:01Z
modify screenshot
commit 8b605c80ac71c9c348ac420c019cf15b1ee14d37
Author: soralee <[email protected]>
Date: 2017-01-27T13:15:56Z
rm old files
commit 6b3881f816d4be0508f7b267a0fa8d047be25b6d
Author: soralee <[email protected]>
Date: 2017-01-30T06:45:26Z
enable homescreen
commit c228f611cd99ec1521746ac188b6ae50bf42159a
Author: soralee <[email protected]>
Date: 2017-01-31T07:11:52Z
enable homescreen without browser error
commit da5b8522e005a9d6d2f14c51514fd1f724ebc279
Author: soralee <[email protected]>
Date: 2017-01-31T12:37:15Z
modify document and screenshot
commit 1422ebe01e46ac4a0780abd1e5fe0657c5bbdcf5
Author: soralee <[email protected]>
Date: 2017-01-31T12:53:17Z
modify document and screenshot
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
