GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/1991

    [ZEPPELIN-2081] Prettify input, textarea in interpreter setting page

    ### What is this PR for?
    
    Fix small details in interpreter setting page about inputboxes, textareas
    
    - Set align middle for `td`
    - Keep same min-height between input and textarea
    - Add border-radius 3px;
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2081](https://issues.apache.org/jira/browse/ZEPPELIN-2081)
    
    ### How should this be tested?
    
    Open the browser and check manually.
    
    ### Screenshots (if appropriate)
    
    #### Before: Invalid align
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/22731438/06a84124-ee2e-11e6-9367-96d59a2dbc2a.png)
    
    #### Before: Inconsistent min-height
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/22731449/0bdab870-ee2e-11e6-9ee3-450e1b1508bf.png)
    
    #### After: align
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/22731451/11a303f2-ee2e-11e6-9ed4-708ca01e637d.png)
    
    #### After: min-height
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/22731456/15f295ee-ee2e-11e6-915d-e9d7d6236bbd.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2081/prettify-intp-setting-boxes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1991
    
----
commit 7e2499b90b58088316eac35fc89cc9bef04501a7
Author: 1ambda <1am...@gmail.com>
Date:   2017-02-08T09:36:37Z

    feat: Set middle align, min height

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to