GitHub user astroshim reopened a pull request:

    https://github.com/apache/zeppelin/pull/1985

    [ZEPPELIN-2075] Can't stop infinite `while` statement in pyspark 
Interpreter.

    ### What is this PR for?
    If following code runs with Pyspark Interpreter, there is no way to cancel 
except Zeppelin Server restart.
    ```
    %spark.pyspark
    import time
    
    while True:
        time.sleep(1)
        print("running..")
    ```
    
    ### What type of PR is it?
    Bug Fix | Improvement
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2075
    
    
    ### How should this be tested?
    Run above code with Pyspark Interpreter and try to cancel.
    
    
    ### Screenshots (if appropriate)
    - before
    ![pyspark 
before](https://cloud.githubusercontent.com/assets/3348133/22696141/615c1206-ed90-11e6-9bbb-339ecdec73fc.gif)
    
    
    - after
    ![pyspark 
after](https://cloud.githubusercontent.com/assets/3348133/22696168/70899172-ed90-11e6-99e1-342eb4094b2c.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-2075

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1985.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1985
    
----
commit 6731e5628c5c139bd9f7189416a0312313cfda7a
Author: astroshim <hss...@zepl.com>
Date:   2017-02-07T14:47:45Z

    add signal to cancel job

commit 65d8cc697179d1e12f18e95cc04e30a43608e7cb
Author: astroshim <hss...@zepl.com>
Date:   2017-02-07T14:54:23Z

    init python pid variable

commit 678c183000ce194cfd17c8a6979ccedf6611a83f
Author: astroshim <hss...@zepl.com>
Date:   2017-02-08T04:23:58Z

    remove signal handler

commit c0cac4ee0df9bf3140c3465da5a4679dca87f6c1
Author: astroshim <hss...@zepl.com>
Date:   2017-02-08T04:36:03Z

    fix logging

commit f26eacf5041eb266d04c237df50be42fdd86f87b
Author: astroshim <hss...@zepl.com>
Date:   2017-02-12T03:30:22Z

    add test-case for canceling.

commit b60d89a5ba4aae0fb983dcfea2bed1b03e1349b6
Author: astroshim <hss...@zepl.com>
Date:   2017-02-15T06:06:57Z

    Merge branch 'master' into ZEPPELIN-2075

commit bc12eaaec6dcfe06911359ed5cae7f9d663d66e0
Author: astroshim <hss...@zepl.com>
Date:   2017-02-15T08:11:14Z

    pass pid to java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to