GitHub user Remilito opened a pull request:

    https://github.com/apache/zeppelin/pull/2042

    [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

    ### What is this PR for?
    * bump nvd3 to 1.8.5 (and remove depecrated functions)
    * display percentage in pie chart [solve ZEPPELIN-1891]
    
    NB: visualization-scatterchart.js's tooltip content generator has been 
updated to stop using depecrated tooltip property and use 
tooltip.contentGenerator instead. However I have commented the code as I think 
nvd3 scatterchart's default tooltip is far more elegant, open to discussion.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - 
    
    ### What is the Jira issue?
    * <https://issues.apache.org/jira/browse/ZEPPELIN-1588>
    * <https://issues.apache.org/jira/browse/ZEPPELIN-1891>
    
    ### How should this be tested?
    Visual testing of the builtin visualization.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1588

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2042
    
----
commit f0b3961547706f18b4b30fa36b93aeda7f24cc58
Author: Remilito <remy.ga...@gmail.com>
Date:   2017-02-20T13:26:45Z

    [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
    * remove deprecated calls
    * solve pie display pct
    * better tooltip for scatterchart

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to