GitHub user 1ambda reopened a pull request:

    https://github.com/apache/zeppelin/pull/2118

    [ZEPPELIN-2242] Toggle helium type buttons

    ### What is this PR for?
    
    Toggle helium type buttons so that user can distinguish which button is 
clicked easily. Previously,
    
    - it's hard to get noticed that `VISUALIZATION` button is clicked by 
default.
    - and buttons lose their focus when user clicks anything.
    
    I attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2242](https://issues.apache.org/jira/browse/ZEPPELIN-2242)
    
    ### How should this be tested?
    
    1. Open `/#helium` page
    2. Click buttons. (refer the screenshots below)
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![before_2242](https://cloud.githubusercontent.com/assets/4968473/23785456/1887d4ba-05ab-11e7-93fa-1a67fb45ae74.gif)
    
    #### After
    
    
![2242_after](https://cloud.githubusercontent.com/assets/4968473/23785459/1bd0d0cc-05ab-11e7-9e12-b144822ccf2c.gif)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2242/toggle-helium-type-buttons

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2118
    
----
commit e4e59bc9d2d39f57f87edc053f3ec17b101d4c22
Author: 1ambda <1am...@gmail.com>
Date:   2017-03-10T06:59:07Z

    feat: Toggle helium type buttons

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to