GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/2159

    [HOTFIX] Handle removing interpreters while removing note

    ### What is this PR for?
    Removing some interpreters while removing note. In case of "Per note", 
"Isolated" interpreter process should be removed if a note be removed. In case 
of "Scoped" of "Per note", that session should be removed and if there's no 
more session in that process, the process should be removed, too.
    
    ### What type of PR is it?
    [Hot Fix]
    
    ### Todos
    * [x] - Handle removing interpreters when removing note
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. set python interpreter as "per note/scoped"
    1. run ```%python print(1)``` in a note
    1. remove that note
    1. check if python process exists with grep
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin 
hotfix/remove-note-remove-interpreter-instances

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2159
    
----
commit cb3de97ca31b19ec1de43ead5a3bc822b7fbc673
Author: Jongyoul Lee <[email protected]>
Date:   2017-03-19T15:33:50Z

    Added method to handle removing interpreters while removing note

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to