GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2205

    [ZEPPELIN-2330] Helium.html doesn't render spell information only in 
production build

    ### What is this PR for?
    
    Helium.html doesn't render spell information only in production build.
    
    That's because self-closed div doesn't work with `ng-bind-html` when it's 
minified. 
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2330](https://issues.apache.org/jira/browse/ZEPPELIN-2330)
    
    ### How should this be tested?
    
    1. Build `mvn clean package -DskipTests;`
    2. Open `localhost:8080/#/helium.html`
    3. Click the `Spell` tab
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![2330](https://cloud.githubusercontent.com/assets/4968473/24493212/04338b30-1569-11e7-9b20-63eab389c9a5.gif)
    
    #### After
    
    <img width="830" alt="screen shot 2017-03-30 at 4 45 25 pm" 
src="https://cloud.githubusercontent.com/assets/4968473/24493204/fca731d2-1568-11e7-9550-b1e975dbdd55.png";>
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2330/cannot-render-spell-info-in-prod

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2205
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to