GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2212

    [gh-pages] set max size for pagination btn & hide arrows when current page 
is first/last 

    ### What is this PR for?
    As the number of Helium packages is increasing, more pagination buttons 
will be generated accordingly. If we don't set `maxSize`, pagination layout 
will be broken when screen size is small. So I set max size to 5 for it. 
    And also hide unnecessary arrows when current page is on first & last. 
(related feedback is 
https://github.com/apache/zeppelin/pull/2174#issuecomment-289776096 suggested 
by @1ambda)
    
    ### What type of PR is it?
    Improvement | gh-pages
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    Run the website(`gh-pages`) locally as described in 
[here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and click 
pagination button
    
    ### Screenshots (if appropriate)
     - before
    
![before](https://cloud.githubusercontent.com/assets/10060731/24579183/3fa531fa-172b-11e7-90b4-4a4a9b946ef5.gif)
    
     - after
    
![after](https://cloud.githubusercontent.com/assets/10060731/24579184/40e77ed8-172b-11e7-8162-3f66406a8493.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin improve/pagination

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2212
    
----
commit 599e06369cd648def8c7e60ec839a2e7d630432a
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-04-01T13:20:55Z

    Set maxSize for pagination

commit 3c7cba30d7c0afc5f45a6ebcbce72b4658bdb442
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-04-01T13:21:53Z

    Hide unnecessary first & last button

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to