GitHub user cfries opened a pull request:

    https://github.com/apache/zeppelin/pull/2235

    ZEPPELIN-2375: Avoid modification of CLASSPATH variable.

    The script previously modified the CLASSPATH variable. This may lead to
    an undesired side effect, where the zeppelin server classpath is
    exported to the zeppelin interpreter classpath, see JIRA issue
    ZEPPELIN-2375 for details. Instead of modifying classpath we now work
    the other way around and set ZEPPELIN_CLASSPATH or
    ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use
    ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec
    (runner), respectively.
    
    See also https://issues.apache.org/jira/browse/ZEPPELIN-2375
    
    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cfries/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2235
    
----
commit 72dbdb40b9b5638e0670182962d3fae987ceaad4
Author: Christian Fries <em...@christian-fries.de>
Date:   2017-04-08T20:00:33Z

    ZEPPELIN-2375: Avoid modification of CLASSPATH variable.
    
    The script previously modified the CLASSPATH variable. This may lead to
    an undesired side effect, where the zeppelin server classpath is
    exported to the zeppelin interpreter classpath, see JIRA issue
    ZEPPELIN-2375 for details. Instead of modifying classpath we now work
    the other way around and set ZEPPELIN_CLASSPATH or
    ZEPPELIN_INT_CLASSPATH to include CLASSPATH and then use
    ZEPPELIN_CLASSPATH or ZEPPELIN_INT_CLASSPATH in the corresponding exec
    (runner), respectively.
    
    See also https://issues.apache.org/jira/browse/ZEPPELIN-2375

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to