I think it's more beneficial to include core tests with 6 test disabled, compare to all test disabled. Later we can fix failed test one by one.
Thanks, moon On Thu, Apr 27, 2017 at 8:18 AM Alexander Shoshin < alexander_shos...@epam.com> wrote: > The problem is that some core tests fail at the moment. I had disabled 6 > test classes when I was trying to receive "green" travis build after > enabling core tests. So we can't just enable all tests - it will brake the > travis job. And fixing all tests errors can take a lot of time. > > Regards, > Alexander > > -----Original Message----- > From: moon soo Lee [mailto:m...@apache.org] > Sent: Thursday, April 27, 2017 12:07 AM > To: dev@zeppelin.apache.org > Subject: Re: Travis jobs > > Right, seconds travis job seems doing nothing. > Second travis job supposed to test all core unit tests plus integration > test (except for spark related test). > Could you help fix this problem? > > Best, > moon > > On Tue, Apr 25, 2017 at 1:04 AM Alexander Shoshin < > alexander_shos...@epam.com> wrote: > > > Hi devs! > > > > Does anybody know what is the purpose of the second Travis job? > > > > I thought it should run all core unit tests but I found that it > > doesn't run anything. Actually it runs 5 integration tests from > > org.apache.zeppelin.integration package but all of them are skipped > > because of TEST_SELENIUM=false. As a result we have zeppelin-server > > unit tests which don't used at all (in any of Travis jobs). > > > > I guess that it is because of the exclamation mark in "-Dtest" property: > > -Dtest='!ZeppelinSparkClusterTest,!org.apache.zeppelin.spark.*' > > which is not supported by maven-surefire-plugin of version 2.17 (which > > is used in Zeppelin). Exclamation mark is supported started from 2.19 > > but still does not work properly. Instead of this we can use surefire > "exclude" > > property in pom.xml by passing parameter from command line: > > > > .travis.yaml: > > -Dtests.to.exclude='ZeppelinSparkClusterTest,org.apache.zeppelin.spark.*' > > pom.xml: <exclude>${tests.to.exclude}</exclude> > > > > So should we run all core unit tests in the second Travis job or not? > > > > Regards, > > Alexander > > >
