GitHub user benoyantony opened a pull request:
https://github.com/apache/zeppelin/pull/2296
[ZEPPELIN-2463] Avoid Locking interpreterSettings during Notebook deletion
### What is this PR for?
Deletion of a notebook requires locking interpreterSettings. If the
deletion is delayed , then lock is not released. At that point, we cannot run
any notebook because everything is waiting to lock interpreterSettings.
Looking at the code, there is no reason to lock the InterpreterSettings
object in InterpreterSettingManager.removeNoteInterpreterSettingBinding.
Similarly in InterpreterSettingManager.getNoteInterpreterSettingBinding
only interpreterSettingBinding is accessed and its already a thread safe
object. So we can remove synchronization on InterpreterSettings
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2463
### How should this be tested?
Being a concurrency issue, it is difficult to test.
Please see the comments in the jira to see the issue experienced on a
production zeppelin server.
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benoyantony/zeppelin ZEPPELIN-2463
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2296
----
commit ffe40b4e99e75ea1c298bad7f9383874f5c54678
Author: Benoy Antony <[email protected]>
Date: 2017-04-28T06:27:33Z
ZEPPELIN-2463 Avoid Locking interpreterSettings during Notebook deletion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
