Make sense for option 2
moon soo Lee <[email protected]>于2017年5月3日周三 上午9:21写道： > Moving thread to dev@ > > Currently CI on pullrequest is > > - Individual contributor runs Travis - CI > - ASF's Jenkins connected to Apache Zeppelin github repo, and get > information from each contributor's Travis build. > - ASF's Appveyor build each pullrequest. > > CI on branch (master, branch-0.7, ...) is > - ASF's Jenkins build new commits on branch > - ASF's Appveyor build new commits on branch > > > Since Appveyor is enabled, I can see Zeppelin PR build on appveyor waits > very long time in the queue. I think we can have several options on it. > > 1. Keep it as is, > > Pros - Each pullrequest will be verified on windows environment before > merge > Cons - Long wait to get a slot in Appveyor > > 2. Disable Appveyor on Pullreuqest build, keep enable Appveyor on branch > build. > > Pros - Each pullrequest will not wait long time for Appveyor finish the > job. > Cons - If somethings broken on windows, we'll know after PR is merged. > > 3. Let individual contributor setup Appveyor and make Jenkins check it, > like we do it with Travis > > Pros - Both Travis, Appveyor test can be finished quickly on each PR > Cons - Each individual contributor need to setup both Travis, Appveyor. > > > To me, 2) looks reasonable because most of PR are not related to the > windows environment, so recognizing some PR break windows support after > merge will be rare event. And of course we can just submit another patch to > fix that. > > 3) is little bit too much for me, asking all contributors setup both travis > and appveyor. > > What do you guys think? > > Thanks, > moon > > On Wed, Apr 26, 2017 at 6:31 PM moon soo Lee <[email protected]> wrote: > > > Filed an infra issue to enable appveyor support. > > https://issues.apache.org/jira/browse/INFRA-14019 > > > > Thanks, > > moon > > > > > > On Fri, Apr 21, 2017 at 2:22 AM Park Hoon <[email protected]> wrote: > > > >> Thanks for reply @moon. > >> > >> > >> Additionally, i create umbrella issue for windows support > >> > >> - https://issues.apache.org/jira/browse/ZEPPELIN-2440 > >> > >> > >> Regard, > >> > >> Hoon Park > >> > >> On Thu, Apr 20, 2017 at 12:28 PM, moon soo Lee <[email protected]> wrote: > >> > >>> Hi, > >>> > >>> Thanks for staring the thread. > >>> > >>> I've seen almost every month people report build broken on windows. > >>> Windows CI env will definitely help solving the problem. > >>> > >>> I'm +1 on setting up appveyor for the project. > >>> > >>> Due to very high usage on ASF's travis account, Zeppelin project guide > >>> each contributor setup travis account and check success/fail using > Jenkins. > >>> > >>> I don't know how busy ASF's appveyor account. But I think we can first > >>> try just turn on appveyor with ASF's account and see how busy it is. > >>> > >>> Thanks, > >>> moon > >>> > >>> > >>> On Wed, Apr 19, 2017 at 5:15 AM Park Hoon <[email protected]> wrote: > >>> > >>>> Hi all, > >>>> > >>>> Some people are struggling with build Zeppelin in windows. > >>>> > >>>> - > >>>> > http://stackoverflow.com/questions/40498638/install-zeppelin-on-windows/42560442#42560442 > >>>> > >>>> IMO, it's enough to verify that zeppelin works well on windows. > >>>> > >>>> But it's not that hard to setup CI for windows and it's possible to > >>>> execute integration tests on windows, it's useful. As you know, we > have > >>>> some issues related with windows env > >>>> > >>>> - > >>>> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20and%20text%20~%20windows > >>>> > >>>> I found that some apache projects already use appveyor to run CI on > >>>> windows. (sadly, travis doesn't support) > >>>> > >>>> - (thrift) https://github.com/apache/thrift/blob/master/appveyor.yml > >>>> - (arrow) https://issues.apache.org/jira/browse/INFRA-12967 > >>>> > >>>> > >>>> > >>>> Thanks. > >>>> > >>>> > >>>> > >> >
